Call UpdateUserRole from AddUserRole - Extend It! ( Programming in VS2005 & 2008, ASP.Net 2.0 )

Forum General DotNetN... Extend It! ( Pr... Call UpdateUserRole from AddUserRole

5/14/2006 6:52 PM

	Michael Freidgeim
89 posts
geekswithblogs.net/mnf/

Call UpdateUserRole from AddUserRole

Modified By Michael Freidgeim on 5/15/2006 10:12:52 PM)

I've noticed that in DotNetNuke\Library\Components\Security\Roles\RoleController.vb Sub AddUserRole has the following code:

Dim objUserRole As UserRoleInfo = GetUserRole(PortalID, UserId, RoleId)

If objUserRole Is Nothing Then

'Code to AddUserRole omitted for brevity

Else

DataProvider.Instance().UpdateUserRole(objUserRole.UserRoleID, ExpiryDate)

End If
Note that UpdateUserRole doesn't have UserId parameter and sets ExpiryDate for all users in specified role.
Is it a bug?

Michael Freidgeim http://geekswithblogs.net/mnf

5/15/2006 6:09 AM

	cathal connolly
2748 posts
www.cathal.co.uk

Re: Call UpdateUserRole from AddUserRole

It certainly looks a bit odd, I don't that area particularly well, so I'll flag it to Charles who's been doing a lot of work refactoring the entire user and roles area, and see what he thinks. You may wish to record it in the public issuelog so it doesn't get lost and you can trace it.

Thanks,

Cathal

5/15/2006 11:33 AM

	Charles Nurse
2887 posts

Re: Call UpdateUserRole from AddUserRole

There have been significant changes to this area in 3.3/4.1.

I do not think it was a bug anyway, as the contract for the API method requires the user to pass the Expiry date, so it is up to the calling method to ensure that this value is valid.

With regard to the User Id, this value is also not neccessary, as the UserRole is uniquely identified by the UserRoleId.

Charles Nurse DotNetNuke Trustee, Senior Architect, DotNetNuke Coporation	MVP (ASP.NET) and ASPInsiders Member
See my Blog for Articles on .NET, DNN and Module Development

5/15/2006 8:12 PM

	Michael Freidgeim
89 posts
geekswithblogs.net/mnf/

Re: Call UpdateUserRole from AddUserRole

Modified By Michael Freidgeim on 5/30/2006 2:40:51 AM)

cnurse wrote
With regard to the User Id, this value is also not neccessary, as the UserRole is uniquely identified by the UserRoleId.

The function AddUserRole assignes a user to a specified role in dnn_UserRoles and aspnet_UsersInRoles tables.

DataProvider.Instance().UpdateUserRole sets ExpiryDate for all users in specified role.

Note that both calls do NOT work with Roles tables( dnn_Roles or aspnet_Roles).

If it is not bug, there are two different business functions implemented in one RoleController.AddUserRole method. And the second function is not expected based on function name.

I hope that it is fixed by changes in 3.3/4.1

Michael Freidgeim http://geekswithblogs.net/mnf

Page 1 of 1

Forum

General DotNetN...

Extend It! ( Pr...

Call UpdateUserRole from AddUserRole