| |
|
|
|
|
|
|
|
|
|
 |    |  |
 | |  |
 | |  |
 | |  |
 | |  |
 |
|
|
| Scheduler Improvement on DNN 4.3.4 |
|
|
Does anyone now is there any improvement for the schdeuler on DNN433, 434 over DNN 4.02?
In particular I would like to know:
1) Is the scheduler no longer dependent on httpcontect when accessing the User and Portal Info? (This may be belonging to improvement on security modules.)
2) Is the Time-mode (Not the request mode) exdecute correctly? That means, it does not depends on any new request to the web site. Previous version of DNN just does not execute this mode correctly?
3) Any other improvement?
|
|
|
|
 |  |
|
| |
 |  |
|
|
| Re: Scheduler Improvement on DNN 4.3.4 |
|
|
Cathal - I don't suppose you know if there was a change made in the Mail sending class in 4.3.3+?
I used to send mail from the Scheduler but now the Mail method fails because it tries to do a GetCurrentPortalSettings() and there are no Portal Settings because I am in the scheduler?
Is this a new change? TIA
Thanks,
Rodney
Smart-Thinker - Social Networking modules for DotNetNuke The DotNetNuke Directory - Are you listed? PokerDIY - Example Implementation of DNN Social Network Do use DNN a lot? Try the DotNetNuke Toolbar to save you time! |
|
|
|
 |  |
|
|
| Re: Scheduler Improvement on DNN 4.3.4 |
|
|
Rodney, I've had a look through the source and all I can see is a change that looks specific to user registration verified emails in the components/mail/mail.vb that was checked in on 4th July - the new lines are in red below, they don't look like they would effect any non veritication mails. I dont have the 4.3.3 source handy, but I can't see any GetCurrentPortalSettings() reference in 4.3.4
Case MessageType.UserRegistrationVerified subject = "EMAIL_USER_REGISTRATION_VERIFIED_SUBJECT" body = "EMAIL_USER_REGISTRATION_VERIFIED_BODY" If Not HttpContext.Current Is Nothing Then custom = New ArrayList custom.Add(HttpContext.Current.Server.UrlEncode(user.Username)) End If
Cathal |
|
|
|
 |  |
|
|
| Re: Scheduler Improvement on DNN 4.3.4 |
|
|
Cheers Cathal - it's in the overloaded SendMail(). Interesting, I am using the 4.3.3 source and I don't see that new code...
Public Shared Function SendMail(ByVal MailFrom As String, ByVal MailTo As String, _ ByVal Cc As String, ByVal Bcc As String, ByVal Priority As MailPriority, _ ByVal Subject As String, ByVal Bodyformat As Mailformat, _ ByVal BodyEncoding As System.Text.Encoding, ByVal Body As String, _ ByVal Attachment As String, ByVal SMTPServer As String, ByVal SMTPAuthentication As String, _ ByVal SMTPUsername As String, ByVal SMTPPassword As String) As String
If MailFrom = PortalController.GetCurrentPortalSettings().Email Or MailFrom = CStr(Common.Globals.HostSettings("HostEmail")) Then MailFrom = """" & PortalController.GetCurrentPortalSettings().PortalName & """ <" & MailFrom & ">" End If
This line is always null as I am not in a portal in the sheduler. OMG.... I just downloaded 4.3.4 and that line has been removed...
Public Shared Function SendMail(ByVal MailFrom As String, ByVal MailTo As String, _ ByVal Cc As String, ByVal Bcc As String, ByVal Priority As MailPriority, _ ByVal Subject As String, ByVal Bodyformat As Mailformat, _ ByVal BodyEncoding As System.Text.Encoding, ByVal Body As String, _ ByVal Attachment As String, ByVal SMTPServer As String, ByVal SMTPAuthentication As String, _ ByVal SMTPUsername As String, ByVal SMTPPassword As String) As String
Dim objMail As New System.Net.Mail.MailMessage(MailFrom, MailTo) If Cc <> "" Then objMail.CC.Add(Cc) End If If Bcc <> "" Then objMail.Bcc.Add(Bcc) End If objMail.Priority = CType(Priority, Net.Mail.MailPriority) objMail.IsBodyHtml = CBool(IIf(Bodyformat = Mailformat.Html, True, False))
If Attachment <> "" Then objMail.Attachments.Add(New Net.Mail.Attachment(Attachment)) End If
Wow - that's cost me about 5 days in dev time!
Ok - thanks for that Cathal - I didn't think the 4.3.4 SendMail method had changed... that means it should work after I upgrade!
Thanks,
Rodney
Smart-Thinker - Social Networking modules for DotNetNuke The DotNetNuke Directory - Are you listed? PokerDIY - Example Implementation of DNN Social Network Do use DNN a lot? Try the DotNetNuke Toolbar to save you time! |
|
|
|
|  |
 | |  |
 | |  |
 | |  |
|  |
| |
 |
|
These Discussion Forums are dedicated to the discussion of the DotNetNuke Web Application Framework.
For the benefit of the community and to protect the integrity of the project, please observe the following posting guidelines:
1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DotNetNuke.
2. Discussion or promotion of DotNetNuke product releases under a different brand name are strictly prohibited.
3. No Flaming or Trolling.
4. No Profanity, Racism, or Prejudice.
5. Site Moderators have the final word on approving/removing a thread or post or comment.
6. English language posting only, please.
|
| |
 |
|
|
|
|
|
|
|